feat: custom header by passing html element #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwlee1108
approved these changes
Aug 28, 2023
sunyoungBae
approved these changes
Aug 28, 2023
heenakwag
approved these changes
Aug 28, 2023
Comment on lines
+2
to
12
| Dictionary, | ||
| OptCellEditor, | ||
| OptCellRenderer, | ||
| OptColumn, | ||
| OptColumnHeaderInfo, | ||
| OptComplexColumnInfo, | ||
| Dictionary, | ||
| OptFilter, | ||
| OptRowHeader, | ||
| OptRowHeaderColumn, | ||
| OptTree, | ||
| } from '@t/options'; |
There was a problem hiding this comment.
P5: grid의 eslint에는 sort-imports 규칙이 없는데 import가 파일마다 변경되어 있네요. 개인 설정에 이 규칙이 적용되어 있는건지 확인 부탁드려요.
원래 sort-imports 규칙이 없다보니 다른 파일도 전부 import가 정렬되어 있지 않아서 확인하는 파일마다 전부 변경사항이 생길텐데, 사실 이건 PR과 무관한 변경사항이라서요. 만약 sort-imports를 적용하는게 좋을 것 같다면 PR 새로 만들어서 한번에 전부 변경하도록 하면 좋을 것 같습니다.
There was a problem hiding this comment.
intellij에 설정되어 있어서 변경되었나 보네요... 이건 추후에 한번에 변경하도록 하겠습니다 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
To-Be
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨